This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Meador Inge <meadori at codesourcery dot com>
Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
Date: Fri, 13 Jun 2014 03:31:54 +0530
Subject: Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
Authentication-results: sourceware.org; auth=none
References: <1402591036-29454-1-git-send-email-meadori at codesourcery dot com> <20140612171519 dot GN10378 at spoyarek dot pnq dot redhat dot com> <539A0BF4 dot 6000603 at codesourcery dot com> <20140612203737 dot 763EC2C39B8 at topped-with-meat dot com> <20140612205413 dot GR10378 at spoyarek dot pnq dot redhat dot com> <17D dot 7060501 at codesourcery dot com>

On Wed, Dec 31, 1969 at 06:06:21PM -0600, Meador Inge wrote:
> Therefore two close call to 'get_nprocs' at that time point will
> cause the value to be computed both times.  I prefer the first patch
> where correctness and the caching behavior is maintained, but I
> understand if others value the simpler approach that sacrifices a
> caching corner-case while still fixing correctness.

I'd say correctness trumps here, even if it is an obscure corner case.
I'll push it tomorrow if nobody objects.

Siddhesh

Attachment: pgpgN7lr1kUCp.pgp
Description: PGP signature

References:
- [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Meador Inge
- Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Siddhesh Poyarekar
- Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Meador Inge
- Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Roland McGrath
- Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Siddhesh Poyarekar
- Re: [PATCH][BZ #16996] get_nprocs: Only return explictly set cache values
  - From: Meador Inge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]