This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix to malloc checking

From: Mike Frysinger <vapier at gentoo dot org>
To: James Lemke <jwlemke at codesourcery dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at suse dot de>, Will Newton <will dot newton at gmail dot com>
Date: Sun, 12 Apr 2015 04:09:44 -0400
Subject: Re: [PATCH] fix to malloc checking
Authentication-results: sourceware.org; auth=none
References: <CANu=DmhJ3FqfxCKqoVyuS77UiJ92V8+a3ZuKo3xPX1pxppbxkw at mail dot gmail dot com> <54762A68 dot 5050801 at codesourcery dot com> <mvma92uqwhg dot fsf at hawking dot suse dot de> <54D26B54 dot 9050707 at codesourcery dot com> <20150302030859 dot GN19363 at vapier> <550082A3 dot 2010503 at codesourcery dot com> <20150405030555 dot GH16816 at vapier> <5523DF4B dot 9070407 at codesourcery dot com> <20150408031058 dot GT16816 at vapier> <55254C2E dot 4040504 at codesourcery dot com>

On 08 Apr 2015 11:41, James Lemke wrote:
> +      block_sz = i - req_sz;
> +      if (block_sz > 0xff)
> +        block_sz = 0xff;

these three lines can be written:
	block_sz = min (i - req_sz, 0xff);

> +      /* Don't allow the magic byte to appear in the chain of length bytes.
> +         For the following to work, magicbyte() cannot return 0x01.  */

GNU style says to omit the () in comments

> +      m_ptr[i] = (unsigned char) block_sz;

i wonder if the cast is really needed ... they're both unsigned already

otherwise patch looks fine to me
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] fix to malloc checking
  - From: James Lemke

References:
- Re: [PATCH] fix to malloc checking
  - From: Mike Frysinger
- Re: [PATCH] fix to malloc checking
  - From: James Lemke
- Re: [PATCH] fix to malloc checking
  - From: Mike Frysinger
- Re: [PATCH] fix to malloc checking
  - From: James Lemke

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]