Re: [PATCH] libio: use PTR_MANGLE/PTR_DEMANGLE for FILE vtables

[Mike Frysinger <vapier at gentoo dot org>]

On 23 May 2016 13:40, Kees Cook wrote:
> On Mon, May 23, 2016 at 1:34 PM, Mike Frysinger wrote:
> > On 23 May 2016 13:02, Kees Cook wrote:
> >> --- a/libio/libioP.h
> >> +++ b/libio/libioP.h
> >> +static inline void
> >> +__mangle_vtable(const struct _IO_jump_t **vtable, const struct _IO_jump_t *table)
> >
> > any reason to not use a name like "_IO_mangle_vtable" ?
> >
> > GNU style says to put a space before the (
> >
> >> +{
> >> +    struct _IO_jump_t *ptr = (struct _IO_jump_t *)table;
> >> +#ifndef USE_COMPAT_LIBIO
> >> +    PTR_MANGLE (ptr);
> >> +#endif
> >> +    *vtable = ptr;
> >> +}
> >
> > GNU style says indent with 2 spaces rather than 4
> 
> Should I fix these up and resend, or are those trivial enough to get
> fixed up during commit?

we like to be lazy and force the submitter to do all the work.
that way we can `git am` it from our mailbox or from patchwork.

plus, that way we don't have to do all the [re]testing ourselves.
-mike

Attachment: signature.asc
Description: Digital signature