This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Consolidate Linux accept implementation
- From: Phil Blundell <pb at pbcl dot net>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Thu, 09 Feb 2017 19:14:34 +0000
- Subject: Re: [PATCH 1/4] Consolidate Linux accept implementation
- Authentication-results: sourceware.org; auth=none
- References: <1485784926-2172-1-git-send-email-adhemerval.zanella@linaro.org> <1485784926-2172-2-git-send-email-adhemerval.zanella@linaro.org> <1486587580.1603.24.camel@pbcl.net> <102dbb40-69f8-4358-03b5-3ea9e6961a2e@linaro.org>
On Wed, 2017-02-08 at 21:26 -0200, Adhemerval Zanella wrote:
>
> And this snippet is indeed wrong as you pointed out, m68k (and any
> other
> architecture) just need to undef is for kernel < 4.3 as:
>
> diff --git a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> index 6811a28..0f31f86 100644
> --- a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> @@ -27,7 +27,6 @@
> # define __ASSUME_BIND_SYSCALL 1
> # define __ASSUME_CONNECT_SYSCALL 1
> # define __ASSUME_LISTEN_SYSCALL 1
> -# define __ASSUME_ACCEPT4_FOR_ACCEPT_SYSCALL 1
> # define __ASSUME_GETSOCKOPT_SYSCALL 1
> # define __ASSUME_SETSOCKOPT_SYSCALL 1
> # define __ASSUME_GETSOCKNAME_SYSCALL 1
> @@ -42,6 +41,7 @@
> #include_next <kernel-features.h>
>
> #if __LINUX_KERNEL_VERSION < 0x040300
> +# undef __ASSUME_ACCCEPT_SYSCALL
> # undef __ASSUME_ACCEPT4_SYSCALL
> # undef __ASSUME_RECVMMSG_SYSCALL
> # undef __ASSUME_SENDMMSG_SYSCALL
Thanks, that makes sense. I think you've still got too many "C"s in
"ACCEPT" in that last hunk above though.
p.