This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Assume that _DIRENT_HAVE_D_TYPE is always defined.
On 10/30/2017 08:18 AM, Florian Weimer wrote:
>> (b) Stop sharing this source file with gnulib, update the
>> SharedSourceFiles not to list the file. Provide a comment in the
>> file stating all of the historical details and why we are not
>> sharing anymore.
>
> If we do that, we should remove the other untested clutter as well,
> and the d_type cleanup would just be a tiny part of that.
>
> I expect that we can't import gnulib getcwd because the code calls
> system getcwd under certain circumstances, and that's obviously a bad
> idea when we use it to implement system getcwd. We could compile it
> with the appropriate preprocessor flags so that this does not happen,
> but our own goals and gnulib's clearly have diverged by this point.
That sounds like good rationale for (b) then.
Please start a new thread if you haven't.
--
Cheers,
Carlos.