This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Filter out NPTL internal signals (BZ #22391)


On 03/11/2017 21:55, Joseph Myers wrote:
> On Fri, 3 Nov 2017, Adhemerval Zanella wrote:
> 
>> What about rename linux nptl-signals.h to internal-signals.h, add
>> a generic version sysdeps/generic instead of sysdeps/nptl, and
>> rename the __nptl_* function to just __*?
> 
> I'd expect internal-signals.h to have just those interfaces used in 
> generic code (and anything those depend on); if there are nptl-signals.h 
> interfaces that the generic code doesn't use, I'd suggest those remain in 
> a separate nptl-signals.h header.
> 

For the default generic interface it will be just the empty default
definitions for the functions used in generic code.  On Linux the
definitions and function on header are not only NPTL related, but 
used for other posix definitions as well (for instance SIGTIMER for 
posix times, SIGSETXID for id functions, and signal block/restore 
helpers).

I think rename the header as is to internal-signals.h makes more
sense.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]