This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.

From: Florian Weimer <fweimer at redhat dot com>
To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
Date: Tue, 13 Mar 2018 12:59:49 +0100
Subject: Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.
Authentication-results: sourceware.org; auth=none
References: <20180307193205.4751-1-zackw@panix.com> <20180307193205.4751-7-zackw@panix.com>

On 03/07/2018 08:32 PM, Zack Weinberg wrote:

+/* __vsyslog_internal uses the same mode_flags bits as
+   __v*printf_internal; see libio/libioP.h.  */
+extern void __vsyslog_internal (int pri, const char *fmt, __gnuc_va_list ap,
+                                unsigned int mode_flags)
+     __attribute__ ((__format__ (__printf__, 2, 0)));

I'm surprised that this doesn't need attribute_hidden orlibc_hidden_proto to avoid new PLT calls.


Rest looks okay.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.
  - From: Zack Weinberg

References:
- [PATCH 0/9] Use more flags parameters instead of global bits in stdio
  - From: Zack Weinberg
- [PATCH 6/9] Add __vsyslog_internal, with same flags as __v*printf_internal.
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]