This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix signed integer overflow in random_r (bug 17343)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 20 Mar 2018 10:58:12 -0700
Subject: Re: Fix signed integer overflow in random_r (bug 17343)
References: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk> <be4d13fb-ba70-681d-63ce-ba2bed6ead68@cs.ucla.edu> <alpine.DEB.2.20.1803201754080.4945@digraph.polyomino.org.uk>

On 03/20/2018 10:54 AM, Joseph Myers wrote:

        *result = (val >> 1) & 0x7fffffff;

One other thing I just noticed: now that val is uint32_t, the aboveshould be simplifed to "*result = val >> 1;". The patch looks goodotherwise; thanks.

References:
- Fix signed integer overflow in random_r (bug 17343)
  - From: Joseph Myers
- Re: Fix signed integer overflow in random_r (bug 17343)
  - From: Paul Eggert
- Re: Fix signed integer overflow in random_r (bug 17343)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]