This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] arm: Remove ununsed ARM code in optimized implementation
- From: Phil Blundell <pb at pbcl dot net>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Mon, 16 Apr 2018 15:55:23 +0100
- Subject: Re: [PATCH] arm: Remove ununsed ARM code in optimized implementation
- References: <1523877749-8457-1-git-send-email-adhemerval.zanella@linaro.org>
On Mon, 2018-04-16 at 08:22 -0300, Adhemerval Zanella wrote:
> This patch removes the ununsed ARM code path for armv6t2 memchr and
> strlen and armv7 memch and strcmp. In all implementations, the ARM
> code is not used in any possible build (unless glibc is explicit
> build with the non-documented NO_THUMB define) and for armv7
> the resulting code either produces wrong results (memchr) and throw
> build error (strcmp).
Thanks, looks good to me.
> Checked on arm-linux-gnueabihf built targeting both armv6 and
> armv7.
Can you confirm there were no changes in the generated binaries?
p.