This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] arm: Remove ununsed ARM code in optimized implementation



On 16/04/2018 11:55, Phil Blundell wrote:
> On Mon, 2018-04-16 at 08:22 -0300, Adhemerval Zanella wrote:
>> This patch removes the ununsed ARM code path for armv6t2 memchr and
>> strlen and armv7 memch and strcmp.  In all implementations, the ARM
>> code is not used in any possible build (unless glibc is explicit
>> build with the non-documented NO_THUMB define) and for armv7
>> the resulting code either produces wrong results (memchr) and throw
>> build error (strcmp).
> 
> Thanks, looks good to me.
> 
>> Checked on arm-linux-gnueabihf built targeting both armv6 and
>> armv7.
> 
> Can you confirm there were no changes in the generated binaries?
> 
> p.
I saw no different on shared libraries built with and without this
patch. I will apply this patch shortly.
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]