This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nscd: Deallocate existing user names in file parser
- From: DJ Delorie <dj at redhat dot com>
- To: fweimer at redhat dot com (Florian Weimer)
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 13 Aug 2018 14:33:11 -0400
- Subject: Re: [PATCH] nscd: Deallocate existing user names in file parser
fweimer@redhat.com (Florian Weimer) writes:
> - server_user = xstrdup (arg1);
> + {
> + free ((char *) server_user);
> + server_user = xstrdup (arg1);
> + }
server_user is global and unitialized, so initialized to NULL. free()
allows the passed pointer to be NULL. So this is OK.
Note that free() nominally takes a void*, not a char*. I think we
should use void* in this case.
> {
> + free ((char *) stat_user);
> stat_user = xstrdup (arg1);
Same here.