This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nscd: Deallocate existing user names in file parser
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 13 Aug 2018 21:57:33 +0200
- Subject: Re: [PATCH] nscd: Deallocate existing user names in file parser
- References: <xnsh3ii0bc.fsf@greed.delorie.com>
* DJ Delorie:
> fweimer@redhat.com (Florian Weimer) writes:
>> - server_user = xstrdup (arg1);
>> + {
>> + free ((char *) server_user);
>> + server_user = xstrdup (arg1);
>> + }
>
> server_user is global and unitialized, so initialized to NULL. free()
> allows the passed pointer to be NULL. So this is OK.
>
> Note that free() nominally takes a void*, not a char*. I think we
> should use void* in this case.
My idea was to make clear that I'm casting away const here (similar to
C++'s const_cast).