This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gabriel at inconstante dot eti dot br, "Carlos O'Donell" <carlos at redhat dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Wed, 14 Nov 2018 19:01:35 +0100
- Subject: Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
- References: <CALoOobN2H0dRjGUT_XSwYSO0pE_kWyVDoGrg+dSN_J4J5zpyJQ@mail.gmail.com> <03b9e2fe-0851-77b2-2ad4-d99aeaa362a2@redhat.com> <CALoOobPARbnzay8bSpGPXPxAJp-wkOvFFaQT1z8cbsQeGCxJYw@mail.gmail.com> <20181113115906.0d5e5b22@tereshkova.br.ibm.com> <CALoOobO2MwM5W-iOY7VtZBgsaUxNs5G4r_fMpMhDA2TM8iqCcg@mail.gmail.com>
* Paul Pluzhnikov:
> + atexit (NULL); /* Should assert. */
> + exit (EXIT_FAILURE);
I think this will print assertion failure messages to the build log,
which is confusing to anyone reviewing it for unexpected errors. Can we
avoid this?
Thanks,
Florian