This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: gabriel at inconstante dot eti dot br, "Carlos O'Donell" <carlos at redhat dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Thu, 15 Nov 2018 13:38:41 -0800
Subject: Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
References: <CALoOobN2H0dRjGUT_XSwYSO0pE_kWyVDoGrg+dSN_J4J5zpyJQ@mail.gmail.com> <03b9e2fe-0851-77b2-2ad4-d99aeaa362a2@redhat.com> <CALoOobPARbnzay8bSpGPXPxAJp-wkOvFFaQT1z8cbsQeGCxJYw@mail.gmail.com> <20181113115906.0d5e5b22@tereshkova.br.ibm.com> <CALoOobO2MwM5W-iOY7VtZBgsaUxNs5G4r_fMpMhDA2TM8iqCcg@mail.gmail.com> <87h8gja680.fsf@oldenburg.str.redhat.com>

On Wed, Nov 14, 2018 at 10:01 AM Florian Weimer <fweimer@redhat.com> wrote:

> I think this will print assertion failure messages to the build log,

Indeed it does:

tst-bz20544: cxa_atexit.c:41: __internal_atexit: Assertion `func !=
NULL' failed.
tst-bz20544: on_exit.c:31: __on_exit: Assertion `func != NULL' failed.
tst-bz20544: cxa_atexit.c:41: __internal_atexit: Assertion `func !=
NULL' failed.

> which is confusing to anyone reviewing it for unexpected errors.  Can we
> avoid this?

Revised patch attached. Thanks!
-- 
Paul Pluzhnikov

Attachment: glibc-bz20544-20181115.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
  - From: Adhemerval Zanella

References:
- Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
  - From: Gabriel F. T. Gomes
- Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ#20544 (assert function passed to atexit/on_exit/__cxa_atexit != NULL)
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]