Re: [PATCHv2] Add --no-hard-links option to localedef (Bug 23923)

[Carlos O'Donell <carlos at redhat dot com>]

On 11/26/18 2:33 PM, Carlos O'Donell wrote:
> On 11/26/18 2:26 PM, Florian Weimer wrote:
>> * Carlos O'Donell:
>>
>>> On 11/26/18 11:58 AM, Joseph Myers wrote:
>>>> On Mon, 26 Nov 2018, Carlos O'Donell wrote:
>>>>
>>>>> If the downstream distro wants to post-process the hardlinks then
>>>>> the time spent in localedef looking up sibling directories and
>>>>> processing hardlinks is wasted effort.
>>>>
>>>> Do you have figures for the time involved?
>>>
>>> On a fast SSD the -j1 locale build and install of SUPPORTED locales
>>> is 3% faster, or for me roughly ~10s on a:
>>> "make localedata/install-locale-files DESTDIR=..." iteration.
>>>
>>> The option itself ensures that no hard links are present and that may
>>> make the logic of the post-install hardlink creation phase simpler.
>>> So there is more than just performance to consider.
>>
>> The real performance win comes from the ability to use parallel make and
>> still get fully deterministic results.
> 
> If you are OK with v2 then I'll give it a few days for others to comment
> and then commit. In v2 I switch the 'make localedata/install-locale-files'
> to use --no-hard-links as the default distribution way to install the
> files deterministically regardless of build paralleism.
> 

OK, I've pushed v2, and this alters 'make localedata/install-locale-files'

I have also added a note in the "Packaging Changes" for distribution maintainers
to read regarding the change in the convenience target:

https://sourceware.org/glibc/wiki/Release/2.29#Localedata_installation_without_hard_links

-- 
Cheers,
Carlos.