Re: [PATCH v5 1/1] Add statx conditionals for wordsize-32 *xstat.c

[Mao Han <han_mao at c-sky dot com>]

On Mon, Dec 17, 2018 at 01:41:49PM +0000, Joseph Myers wrote:
> There is one thing to watch on this patch for future reference (no action 
> required at present).  statx always uses 64-bit timestamps, so for 32-bit 
> systems __cp_stat64_statx will quietly set the timestamps to just the low 
> 32 bits of the timestamps provided by the kernel.  Now, this currently 
> matches what the Linux kernel does for the stat syscalls on 32-bit systems 
> that have them, when using a filesystem that supports timestamps outside 
> the 32-bit time_t range.  But if the Linux kernel changes its handling of 
> such out-of-range timestamps in future (whether producing EOVERFLOW 
> errors, saturating or anything else - there has been past discussion, see 
> <https://bugzilla.redhat.com/show_bug.cgi?id=1419736> and linux-fsdevel 
> link therein, but I'm not sure there was any conclusion), the stat 
> emulation using statx should change to match.

Ok, I'll pay attention to the linux timestamps handling changes.

Thanks,
Mao Han