This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Fix join/tryjoin comments.
* Adhemerval Zanella:
> On 12/02/2019 09:39, Adhemerval Zanella wrote:
>>
>>
>> On 12/02/2019 07:55, Florian Weimer wrote:
>>> * Carlos O'Donell:
>>>
>>>> Why is the comment wrong? Or do you mean to say the comment could be
>>>> made more accurate?
>>>
>>> Let's go back a step. My understanding is that pthread_join and
>>> pthread_timedjoin_np are both cancellation points, but
>>> pthread_tryjoin_np is not. Are you saying that pthread_timedjoin_np is
>>> not a cancellation point?
>>>
>>> I assume that would be a bug.
>>
>> This is my mistake done by ce7eb0e90315eb1939ac29f656d39b3db858c092,
>> I refactored lll_wait_tid and wrongly assumed __lll_timedwait_tid is
>> a cancellation point. The lll_wait_tid is only used on
>> __pthread_timedjoin_ex and replicated on arch lowlevellock.h
>> implementation, I think it would be simpler to just move it to
>> nptl/pthread_join_common.c.
>>
>>
>
> I am working on fixing it.
Thanks.
Meanwhile, I filed <https://sourceware.org/bugzilla/show_bug.cgi?id=24215>
with an out-of-tree test case.
Florian