Re: [PATCH] Remove obsolete, never-implemented XSI STREAMS declarations

[Florian Weimer <fweimer at redhat dot com>]

* Carlos O'Donell:

> On 3/14/19 6:50 AM, Florian Weimer wrote:
>> * Carlos O'Donell:
>> 
>>>> diff --git a/NEWS b/NEWS
>>>> index 0a3b6c7a5a..1e66be0d11 100644
>>>> --- a/NEWS
>>>> +++ b/NEWS
>>>> @@ -22,6 +22,9 @@ Deprecated and removed features, and other changes affecting compatibility:
>>>>    definitions in libc will be used automatically, which have been available
>>>>    since glibc 2.17.
>>>>  
>>>> +* The obsolete and never-implemented XSI STREAMS header files <stropts.h>
>>>> +  and <sys/stropts.h> have been removed.
>>>
>>> OK. This might break builds, should it get a packaging change entry here?
>>> https://sourceware.org/glibc/wiki/Release/2.30#Packaging_Changes
>> 
>> So far, I've considered the wiki as cumulative regarding to the NEWS
>> file.  So things covered in NEWS wouldn't have to be mentioned on the
>> wiki.
>
> That is correct.
>
> The packaging changes in the wiki are intended for verbose and expanded
> discussions on the topic. If you had a desire to expand on the topic
> then the NEWS is not the place for that.
>
> For example in the Packaging Changes you might call out:
> ~~~
> The recent removal of XSI STREAMS may break the build of older applications
> that were relying on the stropts.h header but not actually using it for
> anything (cargo culting the include). In this case the fix is relatively
> easy, you drop the include. If the application had optional support for
> streams, but always compiled them in, then you need to check that there
> way to disable the streams support, otherwise you need to remove it entirely.
> In the past there was a Linux kernel module that implemented streams, but
> streams are no longer a supported interface, and have been obsoleted in
> POSIX.
> ~~~

I think it's not necessary; it will only take away attention from more
important issues.  We don't have <stropts.h> in Fedora, and I'm not
aware that we carry any patches which remove #include directives.

It's either not used at all on Linux, or disabled automatically if it's
not available.

Thanks,
Florian