This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 3/6] wcsmbs: Use loop_unroll on wcschr

From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Sat, 23 Mar 2019 12:00:22 -0300
Subject: Re: [PATCH v2 3/6] wcsmbs: Use loop_unroll on wcschr
References: <20190313140317.8894-1-adhemerval.zanella@linaro.org> <20190313140317.8894-3-adhemerval.zanella@linaro.org>

On Wed, Mar 13 2019, Adhemerval Zanella wrote:
> 
> 	* wcsmbs/wcschr.c (WCSCHR): Use loop_unroll.h to parametrize
> 	the loop unroll.

Looks good to me with a minor fix below.

Reviewed-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>

> +  while (1)
> +    UNROLL_REPEAT(UNROLL_NTIMES, ITERATION);
                    ^
Missing space between macro name and parentheses?

References:
- [PATCH v2 1/6] wcsmbs: Add wcscpy loop unroll option
  - From: Adhemerval Zanella
- [PATCH v2 3/6] wcsmbs: Use loop_unroll on wcschr
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]