This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 4/6] powerpc: Use generic wcschr optimization
On Wed, Mar 13 2019, Adhemerval Zanella wrote:
> This patch removes the power6 wcschr optimization and use generic
> implementation instead. Currently both power6 and power7 ifunc variant
> resulting binary are essentially the same and the generic implementation
> with unrolling loop set to 8 also results in similar performance.
The patch looks good to me with the ChangeLog fixed (see below).
Reviewed-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
> * sysdeps/powerpc/Makefile [$(subdir) == wcsmbs] (CFLAGS-wcschr.c):
> New rule.
> * sysdeps/powerpc/power6/wcschr.c: Remove file.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-power6.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-power7.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-ppc32.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c: Likewise.
This file has not been removed, maybe you could just move it...
> * sysdeps/powerpc/powerpc64/multiarch/wcschr-power6.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcschr-power7.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcschr-ppc64.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcschr.c: Likewise.
> * sysdeps/powerpc/powerpc64/power6/wcschr.c: Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/Makefile
> [$(subdir) == wcsmbs] (sysdeps_routines): Remove wcschr-power6 and
> wcschr-power7.
> (CFLAGS-wcschr-power7.c, CFLAGS-wcschr-power6.c): Remove rule.
> * sysdeps/powerpc/powerpc64/multiarch/Makefile: Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c:
> Remove wcschr optimizations.
... Here.