This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] support: Export bindir path on support_path
- From: DJ Delorie <dj at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org, codonell at redhat dot com
- Date: Mon, 13 May 2019 16:59:36 -0400
- Subject: Re: [PATCH 2/3] support: Export bindir path on support_path
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> * support/Makefile (CFLAGS-support_paths.c): Add -DBINDIR_PATH.
> * support/support.h (support_bindir_prefix): New variable.
> * support/support_paths.c [BINDIR_PATH] (support_bindir_prefix):
LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>
> -DINSTDIR_PATH=\"$(prefix)\" \
> - -DLIBDIR_PATH=\"$(libdir)\"
> + -DLIBDIR_PATH=\"$(libdir)\" \
> + -DBINDIR_PATH=\"$(bindir)\"
Ok.
> /* Corresponds to the install's lib/ or lib64/ directory. */
> extern const char support_libdir_prefix[];
> +/* Corresponds to the install's bin/ directory. */
> +extern const char support_bindir_prefix[];
Ok.
> +
> +#ifdef BINDIR_PATH
> +/* Corresponds to the install's bin/ directory. */
> +const char support_bindir_prefix[] = BINDIR_PATH;
> +#else
> +# error please -DBINDIR_PATH=something in the Makefile
> +#endif
Ok.