This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/3] elf: Fix tst-pldd for non-default --prefix and/or --bindir (BZ#24544)
- From: DJ Delorie <dj at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org, codonell at redhat dot com
- Date: Mon, 13 May 2019 17:02:47 -0400
- Subject: Re: [PATCH 3/3] elf: Fix tst-pldd for non-default --prefix and/or --bindir (BZ#24544)
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> [BZ #24544]
> * elf/tst-pldd.c (do_test): Use support_bindir_prefix instead of
> pre-defined value.
LGTM.
Reviewed-by: DJ Delorie <dj@redhat.com>
> +#include <stdlib.h>
For free(), Ok.
> +#include <support/support.h>
For paths, ok.
> - const char prog[] = "/usr/bin/pldd";
> + char *prog = xasprintf ("%s/pldd", support_bindir_prefix);
Ok. Results must be free'd.
> + free (prog);
And free'd. Ok.