This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
- From: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- To: Florian Weimer <fweimer at redhat dot com>, DJ Delorie <dj at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 22 Jul 2019 17:45:33 -0300
- Subject: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
- References: <87k1cekzr9.fsf@oldenburg2.str.redhat.com>
Whenever a sub-make is created, it inherits the variable subdirs from its
parent. This is also true when make check is called with a restricted
list of subdirs. In this scenario, make install is executed "partially"
and testroot.pristine ends up with an incomplete installation.
2019-07-22 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
[BZ #24794]
* Makefile (testroot.pristine/install.stamp): Pass
subdirs='$(all-subdirs)' to make install.
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a4ed747cef..9fbf705200 100644
--- a/Makefile
+++ b/Makefile
@@ -401,7 +401,8 @@ ifeq ($(run-built-tests),yes)
$(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\
done
endif
- $(MAKE) install DESTDIR=$(objpfx)testroot.pristine
+ $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \
+ subdirs='$(all-subdirs)'
touch $(objpfx)testroot.pristine/install.stamp
tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
--
2.14.5