This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
- From: DJ Delorie <dj at redhat dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: fweimer at redhat dot com, libc-alpha at sourceware dot org
- Date: Mon, 22 Jul 2019 16:56:12 -0400
- Subject: Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> writes:
> Whenever a sub-make is created, it inherits the variable subdirs from its
> parent. This is also true when make check is called with a restricted
> list of subdirs. In this scenario, make install is executed "partially"
> and testroot.pristine ends up with an incomplete installation.
"obvious in retrospect" Sigh.
> 2019-07-22 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> [BZ #24794]
> * Makefile (testroot.pristine/install.stamp): Pass
> subdirs='$(all-subdirs)' to make install.
LGTM. Thanks!
Reviewed-by: DJ Delorie <dj@redhat.com>