This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
- From: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- To: DJ Delorie <dj at redhat dot com>, fweimer at redhat dot com, libc-alpha at sourceware dot org
- Cc:
- Date: Tue, 23 Jul 2019 13:29:49 -0300
- Subject: Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
- References: <xny30pkcur.fsf@greed.delorie.com>
DJ Delorie <dj@redhat.com> writes:
> Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> writes:
>> Whenever a sub-make is created, it inherits the variable subdirs from its
>> parent. This is also true when make check is called with a restricted
>> list of subdirs. In this scenario, make install is executed "partially"
>> and testroot.pristine ends up with an incomplete installation.
>
> "obvious in retrospect" Sigh.
>
>> 2019-07-22 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>>
>> [BZ #24794]
>> * Makefile (testroot.pristine/install.stamp): Pass
>> subdirs='$(all-subdirs)' to make install.
>
> LGTM. Thanks!
>
> Reviewed-by: DJ Delorie <dj@redhat.com>
Pushed as 35e038c1d2ccb.
Thanks!
--
Tulio Magno