This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Add nocancel version of pread64()

From: Carlos O'Donell <carlos at redhat dot com>
To: Leandro Pereira <Leandro dot Pereira at microsoft dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>
Date: Tue, 6 Aug 2019 13:09:54 -0400
Subject: Re: [PATCH 1/2] Add nocancel version of pread64()
References: <MWHPR2101MB0732AF4AE4ECE64CB603997BE8DA0@MWHPR2101MB0732.namprd21.prod.outlook.com>

On 8/5/19 5:54 PM, Leandro Pereira wrote:

This is in preparation for changes in the dynamic linker so that pread() is used instead of lseek()+read().

2019-08-05  Leandro Pereira  <leandro.pereira@microsoft.com>

	* sysdeps/generic/not-cancel.h: New macro.
	* sysdeps/unix/sysv/linux/not-cancel.h: New macro.
	* sysdeps/unix/sysv/linux/pread64_nocancel.c: Implement nocancel
	version of pread64.
	* sysdeps/unix/sysv/linux/Versions (GLIBC_PRIVATE): Add
	__pread64_nocancel.
	* sysdeps/unix/sysv/linux/Makefile: Reference pread64_nocancel.c.


I'm am really excited to see changes like this going into glibc.
Whenever we get a chance to do a small optimization like this is great.

I don't see a copyright disclaimer for you on file, and I'm going to
follow up with you privately to see what we can do there to expedite
the process so we can work on your patches as quickly as possible.

Thank you again!

--
Cheers,
Carlos.

References:
- [PATCH 1/2] Add nocancel version of pread64()
  - From: Leandro Pereira

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]