This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] time: Add padding for the timespec if required
On Tue, Sep 24, 2019 at 5:57 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Tue, 24 Sep 2019, Alistair Francis wrote:
>
> > +#if __WORDSIZE == 64 \
> > + || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) || \
> > + __TIMESIZE == 32
>
> || goes at start of line, not at end of line.
>
> > __syscall_slong_t tv_nsec; /* Nanoseconds. */
> > +#else
> > +# if __BYTE_ORDER == __BIG_ENDIAN
> > + int: 32; /* Padding */
> > + long int tv_nsec; /* Nanoseconds */
> > +# else
> > + long int tv_nsec; /* Nanoseconds */
> > + int: 32; /* Padding */
> > +# endif
> > +#endif
>
> The comment formatting in the other cases, with ". " ('.' and two spaces)
> at end of comment, is correct GNU style.
I have fixed all of there.
>
> The patch is OK with those fixes once the <bits/endian.h> changes are
> reviewed and checked in.
Thanks! :)
I don't add a Reviewed-by tag do I?
Alistair
>
> --
> Joseph S. Myers
> joseph@codesourcery.com