Re: [PATCH 2/2] time: Add padding for the timespec if required

[Lukasz Majewski <lukma at denx dot de>]

Hi Alistair, Joseph,

> On Tue, Sep 24, 2019 at 5:57 PM Joseph Myers
> <joseph@codesourcery.com> wrote:
> >
> > On Tue, 24 Sep 2019, Alistair Francis wrote:
> >  
> > > +#if __WORDSIZE == 64 \
> > > +  || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) ||
> > > \
> > > +  __TIMESIZE == 32  
         ^^^^^^^^^^^^^^^^^ - this may be a bit problematic as 32 bit
         systems (with __TIMESIZE == 32) gain support for 64 bit time
         (so the Y2038 problem is solved).

	 Those systems also would require padding (the code below).

	 However, I do guess that allowing such systems to have the
	 extra padding after this patch (by removing __TIMESIZE==32
	 condition) is not an option for now (and shall be done in the
	 same commit which introduces -D_TIME_BITS=64 support to glibc)
	 ?

> >
> > || goes at start of line, not at end of line.
> >  
> > >    __syscall_slong_t tv_nsec; /* Nanoseconds.  */
> > > +#else
> > > +# if __BYTE_ORDER == __BIG_ENDIAN
> > > +  int: 32;           /* Padding */
> > > +  long int tv_nsec;  /* Nanoseconds */
> > > +# else
> > > +  long int tv_nsec;  /* Nanoseconds */
> > > +  int: 32;           /* Padding */
> > > +# endif
> > > +#endif  
> >
> > The comment formatting in the other cases, with ".  " ('.' and two
> > spaces) at end of comment, is correct GNU style.  
> 
> I have fixed all of there.
> 
> >
> > The patch is OK with those fixes once the <bits/endian.h> changes
> > are reviewed and checked in.  
> 
> Thanks! :)
> 
> I don't add a Reviewed-by tag do I?
> 
> Alistair
> 
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com  




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpO9O5m51YP7.pgp
Description: OpenPGP digital signature