This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] nptl: Fix niggles with pthread_clockjoin_np
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Mike Crowe <mac at mcrowe dot com>, libc-alpha at sourceware dot org
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Joseph Myers <joseph at codesourcery dot com>, Florian Weimer <fw at deneb dot enyo dot de>
- Date: Sat, 2 Nov 2019 22:13:04 +0100 (CET)
- Subject: Re: [PATCH v2] nptl: Fix niggles with pthread_clockjoin_np
- References: <bd57f4f58493b896c9f387d223e489f0c89be276.1572691890.git-series.mac@mcrowe.com>
2.11.2019 11:52 Mike Crowe <mac@mcrowe.com> wrote:
>
> Joseph Myers spotted[1] that 69ca4b54c151cec42ccca5e05790efc1a8206b47
> added
> pthread_clockjoin_np to sysdeps/nptl/pthread.h but not to its
> hppa-specific
> equivalent sysdeps/unix/sysv/linux/hppa/pthread.h.
>
> Rafal Luzynski spotted[2] typos in the NEWS entry and manual updates too.
>
> Florian Weimer spotted[3] that the clockid parameter was not using a
> reserved identifier in pthread.h.
>
> [1] https://sourceware.org/ml/libc-alpha/2019-11/msg00016.html
> [2] https://sourceware.org/ml/libc-alpha/2019-11/msg00019.html
> [3] https://sourceware.org/ml/libc-alpha/2019-11/msg00022.html
>
> Fixes: 69ca4b54c151cec42ccca5e05790efc1a8206b47
> ---
> NEWS | 2 +-
> manual/threads.texi | 2 +-
> sysdeps/nptl/pthread.h | 2 +-
> sysdeps/unix/sysv/linux/hppa/pthread.h | 11 +++++++++++
> 4 files changed, 14 insertions(+), 3 deletions(-)
> [...]
LGTM but I'd like to hear a feedback from Joseph and Florian as well.
Thanks and regards,
Rafal