This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] nptl: Fix niggles with pthread_clockjoin_np
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>
- Cc: Mike Crowe <mac at mcrowe dot com>, <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Florian Weimer <fw at deneb dot enyo dot de>
- Date: Mon, 4 Nov 2019 18:13:01 +0000
- Subject: Re: [PATCH v2] nptl: Fix niggles with pthread_clockjoin_np
- Ironport-sdr: RyWi4NU1L9y+aQnUplsFFWuYYhCnImEZEpT+qu0xpIw4rCd3GK8Dt50Evhr8F+FibcwgrPM5SV U805zR02px3a9Hg2sc1KP1EwRfhdgElqVVuM2TVsqOGDQs7ZrEUVfUJKEfVDGjS3u68uZzE/fS etSl+mgcyzVHP+ST0aft3Ie5IQHnRKTcd6a6n9LOIFzkaIWebh/3Qhxphb3k2TJLzBuD46LTBC pNbk6m3GywjqqLXWzUDOaEC7f7L7U4OjL6ktFVFaqJgpPz/sXamtQy7SMPhK2Mc1qI1Nib1z7M 7Lg=
- Ironport-sdr: MHKiKNYhQBZlO7dGS861ex7qavJjkPYBoLkRDbFAzoW/0gU4GKDDi+EDI1zeFINvcZh+khLtkA eQiPFRiApMMW9iQ4NyWSvKRrVmKNCQtkMeo8kleA0YuTXMFRsSeRPjtCHu9LaXs//yaJ9Wsx8v Gx4sfM/JATSZwfz4SL0MPqVIsNHTH6zq2/0Mar/JWnDdLKcZOybpaplgqH0x27XxCy47+F6sOJ aaVaLpJ/NNtbqdvknVhAUPa6KY8pAM+qo4JccrAIgLJCWkFiDjpcOcQqG14tjZ8lynBgc0lvI+ FSI=
- References: <bd57f4f58493b896c9f387d223e489f0c89be276.1572691890.git-series.mac@mcrowe.com> <1601497399.1827810.1572729184497@poczta.nazwa.pl>
On Sat, 2 Nov 2019, Rafal Luzynski wrote:
> 2.11.2019 11:52 Mike Crowe <mac@mcrowe.com> wrote:
> >
> > Joseph Myers spotted[1] that 69ca4b54c151cec42ccca5e05790efc1a8206b47
> > added
> > pthread_clockjoin_np to sysdeps/nptl/pthread.h but not to its
> > hppa-specific
> > equivalent sysdeps/unix/sysv/linux/hppa/pthread.h.
> >
> > Rafal Luzynski spotted[2] typos in the NEWS entry and manual updates too.
> >
> > Florian Weimer spotted[3] that the clockid parameter was not using a
> > reserved identifier in pthread.h.
> >
> > [1] https://sourceware.org/ml/libc-alpha/2019-11/msg00016.html
> > [2] https://sourceware.org/ml/libc-alpha/2019-11/msg00019.html
> > [3] https://sourceware.org/ml/libc-alpha/2019-11/msg00022.html
> >
> > Fixes: 69ca4b54c151cec42ccca5e05790efc1a8206b47
> > ---
> > NEWS | 2 +-
> > manual/threads.texi | 2 +-
> > sysdeps/nptl/pthread.h | 2 +-
> > sysdeps/unix/sysv/linux/hppa/pthread.h | 11 +++++++++++
> > 4 files changed, 14 insertions(+), 3 deletions(-)
> > [...]
>
> LGTM but I'd like to hear a feedback from Joseph and Florian as well.
This patch is OK.
--
Joseph S. Myers
joseph@codesourcery.com