This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: How to keep Reviewed-by lines in git commits with gerrit.

* Jonathan Nieder:

>>> I would prefer it to be automatically added by the review tool, as
>>> gerrit is designed to do.
>>
>> Is it?
>
> The Cherry Pick and Rebase Always submit strategies[1] automatically
> add Reviewed-by footers.
>
> Other submit strategies (like Merge If Necessary) are designed to not
> touch the change uploader's commit (e.g. they may have signed it) so
> they don't add the footer.

> [1]
> https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies

I'm confused.  Is it expected that these changes are not visible in
the commits I can download (under the DOWNLOAD button) or in the web
UI?  Are they added only during the push?
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]