This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Update kernel version to 5.4 in tst-mman-consts.py
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <codonell at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 29 Nov 2019 16:36:48 +0000
- Subject: Re: Update kernel version to 5.4 in tst-mman-consts.py
- Ironport-sdr: 84A6xcXXJ+ByNfvZ134iI3f3DX2R+iYOjUV7gFeXAzXQyZGEhYZBVl3EsXqO+nY+eVV99JII99 m72mKir5L9g8vaNNDXP0Ng3Pagi8ta7mGZ1qeX1GBb05hcSxSlJw5fTK/QEwn9UedTOPISrjsH HCEPcHUP/cfZHGMBSkwTMtLV4eLaP9RnaTLzDu1WX7U4RN8zJNA7nb3o+T73eImRNrzyeYVdBr RiWglaRt4UZIeGV3RoGc8ewTydVi6lVaW/z08U0zxZQqC2hjuv1nsa5JhSj5zpHdCaUjDihcEN 0aA=
- Ironport-sdr: ypsL08AfpmnarrtKkvevgJLpGCBXgTBK4GgnCT5eEfMiZUKkBp2EsfNdENUtoq0FwK00NNia8t kv2ST3ZsuMDj4eUfopEa6ciYZnN30SJKqGnIg2nYQQIMdiVBskB9TLufDfA6V4+5bcsetM76zs TDS5GSsK00zCEniTyDK0XrdJnl3uuziYjZnZi2wmQYdE9PG2Dzjati/DozNpZ1KgnXFwlLSNaz JTCmya0XjCqX6S0heG1fNYKILLrKjSLPRUYJAY3L0h76g3NKtZZ0eChay69c6bNR9DNAoyLTKa 68U=
- References: <alpine.DEB.2.21.1911282305510.9015@digraph.polyomino.org.uk> <9845e599-c755-3824-18cf-4d21d745e2af@redhat.com>
On Thu, 28 Nov 2019, Carlos O'Donell wrote:
> I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_*
> or PKEY_* constants? Is that an oversight or a conscious choice?
The idea when adding the test was to add something sufficient to be
useful that could also be a starting point for adding more such tests
later. It would certainly make sense to test more such macros there.
We now have three such tests (tst-mman-consts.py tst-signal-numbers.py
tst-socket-consts.py). My expectation is that once we have enough, there
will be clear common patterns that allow us to move to having a single
Python script to run them, and text files that describe the headers,
macros (and hopefully structure layouts as well) to compare and any
relevant kernel version information, rather than a separate Python script
for each test. (Cf. how the constant extraction for assembly sources -
which shares code used by these tests - has .sym files rather than a
separate script for each generated header.)
--
Joseph S. Myers
joseph@codesourcery.com