Re: Update kernel version to 5.4 in tst-mman-consts.py

[Carlos O'Donell <codonell at redhat dot com>]

On 11/29/19 11:36 AM, Joseph Myers wrote:
> On Thu, 28 Nov 2019, Carlos O'Donell wrote:
> 
>> I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_*
>> or PKEY_* constants? Is that an oversight or a conscious choice?
> 
> The idea when adding the test was to add something sufficient to be 
> useful that could also be a starting point for adding more such tests 
> later.  It would certainly make sense to test more such macros there.
> 
> We now have three such tests (tst-mman-consts.py tst-signal-numbers.py 
> tst-socket-consts.py).  My expectation is that once we have enough, there 
> will be clear common patterns that allow us to move to having a single 
> Python script to run them, and text files that describe the headers, 
> macros (and hopefully structure layouts as well) to compare and any 
> relevant kernel version information, rather than a separate Python script 
> for each test.  (Cf. how the constant extraction for assembly sources - 
> which shares code used by these tests - has .sym files rather than a 
> separate script for each generated header.)
 
Thanks, that makes sense, I was just curious.

-- 
Cheers,
Carlos.