This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/15] nios2: Use Linux kABI for syscall return

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org, Andreas Schwab <schwab at suse dot de>
Date: Tue, 11 Feb 2020 16:09:17 -0300
Subject: Re: [PATCH 08/15] nios2: Use Linux kABI for syscall return
References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-8-adhemerval.zanella@linaro.org> <87zhdpnzf6.fsf@oldenburg2.str.redhat.com>

On 11/02/2020 08:20, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> +#define INTERNAL_SYSCALL_ERROR_P(val, err) \
>> +  ((unsigned long) (val) >= (unsigned long) -4095)
> 
> This should use unsigned long int.  Rest looks okay.
> 
> Thanks,
> Florian
> 

I didn't bother because this snippet will be removed by the
'linux: Consolidate INLINE_SYSCALL' patch in this set, but you
are correct.

I have changed to:

#define INTERNAL_SYSCALL_ERROR_P(val, err) \
  ((unsigned long) (val) > -4096UL)

(which is the one I used on consolidation).

References:
- [PATCH 01/15] powerpc: Consolidate Linux syscall definition
  - From: Adhemerval Zanella
- [PATCH 08/15] nios2: Use Linux kABI for syscall return
  - From: Adhemerval Zanella
- Re: [PATCH 08/15] nios2: Use Linux kABI for syscall return
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]