This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 09/15] microblaze: Avoid clobbering register parameters in syscall

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 11 Feb 2020 16:10:14 -0300
Subject: Re: [PATCH 09/15] microblaze: Avoid clobbering register parameters in syscall
References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-9-adhemerval.zanella@linaro.org> <87v9odnzcz.fsf@oldenburg2.str.redhat.com>


On 11/02/2020 08:21, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> The microblaze INTERNAL_SYSCALL macro might clobber the register
>> parameter if the argument itself might clobber any register (a function
>> call for instance).
>>
>> This patch fixes it by using temporary variables for the expressions
>> between the register assignments (as indicated by GCC documentation,
>> 6.47.5.2 Specifying Registers for Local Variables).
>>
>> It is similar to the fix done for MIPS (BZ#25523).
> 
> (bug 25523) for the bug reference, so that it will be recognized by the
> commit hook.  Rest looks good.

Ack.

References:
- [PATCH 01/15] powerpc: Consolidate Linux syscall definition
  - From: Adhemerval Zanella
- [PATCH 09/15] microblaze: Avoid clobbering register parameters in syscall
  - From: Adhemerval Zanella
- Re: [PATCH 09/15] microblaze: Avoid clobbering register parameters in syscall
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]