This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 12/15] sparc: Avoid clobbering register parameters in syscall
On 11/02/2020 08:22, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> The sparc INTERNAL_SYSCALL macro might clobber the register
>> parameter if the argument itself might clobber any register (a function
>> call for instance).
>>
>> This patch fixes it by using temporary variables for the expressions
>> between the register assignments (as indicated by GCC documentation,
>> 6.47.5.2 Specifying Registers for Local Variables).
>>
>> It is similar to the fix done for MIPS (BZ#25523).
>
> (bug 25523) for the bug reference. You may also consider switching to
> long int instead of long, given that you change most of the code anyway.
> Otherwise looks good.
Ack I have changed to long int on my local branch.