This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 13/15] linux: Consolidate INLINE_SYSCALL


* Adhemerval Zanella:

>> The comment seems misleading to me.  Does “register saving” really
>> matter here?  I think it's about the -errno behavior.  I think the
>> comment should explain how this macro is to be used (i.e., it sets errno
>> on failure).
>
> Indeed, it is an artefact from powerpc version.   What about:
>
> /* Define a macro which expands into the inline wrapper code for a system
>    call.  It sets the errno and returns -1 on a failure, or the syscall
>    return value otherwise.  */

Looks good.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]