This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 14/15] nptl: Remove ununsed pthread-errnos.h rule
On 11/02/2020 08:51, Florian Weimer wrote:
> * Florian Weimer:
>
>> * Adhemerval Zanella:
>>
>>> ---
>>> nptl/Makefile | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/nptl/Makefile b/nptl/Makefile
>>> index 6f210d60e3..fcdc72adfe 100644
>>> --- a/nptl/Makefile
>>> +++ b/nptl/Makefile
>>> @@ -327,8 +327,7 @@ test-xfail-tst-once5 = yes
>>> # Files which must not be linked with libpthread.
>>> tests-nolibpthread = tst-unload
>>>
>>> -gen-as-const-headers = pthread-errnos.sym \
>>> - unwindbuf.sym \
>>> +gen-as-const-headers = unwindbuf.sym \
>>> pthread-pi-defines.sym
>>>
>>> gen-py-const-headers := nptl_lock_constants.pysym
>>
>> I don't think this is unused?
>
> Sorry, I see the changes now. But why doesn't this patch delete the
> pthread-errnos.sym file as well?
I update the patch to delete it, thanks for catching it.