This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation

From: Lukasz Majewski <lukma at denx dot de>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: Paul Eggert <eggert at cs dot ucla dot edu>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Alistair Francis <alistair23 at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at gotplt dot org>, Florian Weimer <fweimer at redhat dot com>, Florian Weimer <fw at deneb dot enyo dot de>, Zack Weinberg <zackw at panix dot com>, Carlos O'Donell <carlos at redhat dot com>, Andreas Schwab <schwab at suse dot de>
Date: Wed, 12 Feb 2020 10:09:38 +0100
Subject: Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation
References: <20200211165256.21848-1-lukma@denx.de> <alpine.DEB.2.21.2002120104310.3988@digraph.polyomino.org.uk>

Hi Joseph,

> On Tue, 11 Feb 2020, Lukasz Majewski wrote:
> 
> > +int
> > +__mq_timedsend (mqd_t mqdes, const char *msg_ptr, size_t msg_len,
> > +                unsigned int msg_prio, const struct timespec
> > *abs_timeout) +{
> > +  struct __timespec64 ts64;
> > +    if (abs_timeout)
> > +	    ts64 = valid_timespec_to_timespec64 (*abs_timeout);
> > +
> > +    return __mq_timedsend_time64 (mqdes, msg_ptr, msg_len,
> > msg_prio,
> > +                                  abs_timeout ? &ts64 : NULL);
> >  }  
> 
> The indentation seems wrong here.  Likewise in patch 2.
> 

Thanks for spotting it. I will fix it in v2.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgp4Us1d11vxC.pgp
Description: OpenPGP digital signature

References:
- [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation
  - From: Lukasz Majewski
- Re: [PATCH 1/2] y2038: linux: Provide __mq_timedsend_time64 implementation
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]