This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED] S390: Fix non-ascii character in fenv.h.
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Stefan Liebler <stli at linux dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Feb 2020 10:12:19 +0100
- Subject: Re: [COMMITTED] S390: Fix non-ascii character in fenv.h.
- References: <1581495249-12990-1-git-send-email-stli@linux.ibm.com>
* Stefan Liebler:
> The comment "isn't" contained a non-ascii character which leads to
> an error if compiled with -finput-charset=ascii:
> error: failure to convert ascii to UTF-8
>
> This is observable in GCC testsuite:
> FAIL: 17_intro/headers/c++1998/charset.cc (test for excess errors)
> FAIL: 17_intro/headers/c++2011/charset.cc (test for excess errors)
> FAIL: 17_intro/headers/c++2014/charset.cc (test for excess errors)
> FAIL: 17_intro/headers/c++2017/charset.cc (test for excess errors)
> FAIL: 17_intro/headers/c++2020/charset.cc (test for excess errors)
>
> Also rewrite the comment above.
>
> Reported-by: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Looks good.
I think we should add -finput-charset=ascii to check-install-headers.
Do you want to send a patch for that?