This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Consensus on high-level objective of cleanup, refactor or rework patches.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Andreas Schwab <schwab at suse dot de>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Date: Fri, 14 Feb 2020 22:24:49 +0000
- Subject: Re: Consensus on high-level objective of cleanup, refactor or rework patches.
- Ironport-sdr: 2gWeP+Nt7EgdD8FkfeyRAOoV76XiThyNZ1ElF1EGfDW/ErSk0X235UwJv1VrSn1SYAqYt9ibCF OAesnaEgFpRznrfG3rrR/A5q/nmtYfEorGHHdeYy3cdZQrtoaNfmlAqh1o8LFahuzqJMJyxEGL 3y2UYNipNWryDzEB89uMGuqx1JGOMLRpJEZQEmjRFRuqUdPok0oPIWGlIicOeXIp7lpfDlLXRi /PAK4bipBpBQh6POlRlEVunXhraxE4Tgxi8p2QLOmszPKSBLrjLb1NKa6NKdOcVmkQphz0zSHo RIo=
- Ironport-sdr: WygoenQlNNLEP5dwx1aMRv7G//nixZcLtzRRmGvMMrPFLSt8VI/0QZyMuS3zmh8obI7hfWN3Bc Ti+FDr4iX31NbJ1sZgMMw7I9d+EuB6xYep0c5cf26poXFH3UIivswgBDAFeYcSpolYWQw0/1rR rQwGSgVmhrgX3O5+AHhOsXGOD5S5+OXYDr0oKeT2rJAIc7kto05LDv75MmCj2jJW0NECZkX+2Z /IH7Se0UPsWwe57g28JJvvAHdLDxeh+Kte96ppBGov63H1+Y27mLN7PZO5Jdq8uAw2FrpO9KRA OG4=
- References: <CAEMqeSqcGvsmuR9XwqG4v7UkTeBGpcsAD-RHjg9FBPiUZZW93A@mail.gmail.com> <alpine.DEB.2.21.2002141714470.15736@digraph.polyomino.org.uk> <CAEMqeSp5BKBtqjMDMtviFrY+71ZfTcVnvLgp6LvEdj4ut6Nvtg@mail.gmail.com> <alpine.DEB.2.21.2002142114180.21534@digraph.polyomino.org.uk> <CAEMqeSoPxYBL5VTr=XL=f3f7BNLAGL9fGtWd61t2sSHyHGF91Q@mail.gmail.com>
On Fri, 14 Feb 2020, Carlos O'Donell wrote:
> Reviewers, like myself, should consider reviewing *less* when it is
> clearly evident that additional review is not required?
Yes. Consider what it is about the patch that is relevant to review,
taking into account factors such as existing consensus for an overall
design, any relevant expertise of the patch submitter and the quality and
contents of the commit message and the testing described in that commit
message.
--
Joseph S. Myers
joseph@codesourcery.com