This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Consensus on high-level objective of cleanup, refactor or rework patches.
On Fri, Feb 14, 2020 at 5:25 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Fri, 14 Feb 2020, Carlos O'Donell wrote:
>
> > Reviewers, like myself, should consider reviewing *less* when it is
> > clearly evident that additional review is not required?
>
> Yes. Consider what it is about the patch that is relevant to review,
> taking into account factors such as existing consensus for an overall
> design, any relevant expertise of the patch submitter and the quality and
> contents of the commit message and the testing described in that commit
> message.
I appreciate your points about the complexity of implementations.
I will try to review less and see how it goes :-)
Cheers,
Carlos.