This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Thu, 20 Feb 2020 08:54:30 +0100
Subject: Re: [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically
References: <cover.1581418947.git.fweimer@redhat.com> <87037a063582b22acaede4def0245c5042fd8e22.1581418947.git.fweimer@redhat.com> <6611e064-469a-d845-7a48-7f6a9df6c594@linaro.org>

* Adhemerval Zanella:

> On 11/02/2020 08:06, Florian Weimer wrote:
>> This will make it easier to review changes which move implementations
>> from libpthread to libc.
>
> This organization does help a lot not only refactoring, but also new
> files. Maybe we could enforce it from now one, thoughts?

We are using this construct in a few other places.  Andreas did not like
the final line with the trailing \ though.

routines += function

would avoid that, but it has quadratic behavior in make, and that could
be actually visible in a few places.

> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

Thanks for all the reviews.

FlFlorian

References:
- [PATCH 00/13] nptl: Move more functions from libpthread to libc
  - From: Florian Weimer
- [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically
  - From: Florian Weimer
- Re: [PATCH 02/13] nptl: Sort routines list in Makefile alphabetically
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]