This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>, Lukasz Majewski <lukma at denx dot de>, Andreas Schwab <schwab at suse dot de>, "fweimer at redhat dot com" <fweimer at redhat dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "palmerdabbelt at google dot com" <palmerdabbelt at google dot com>, "zongbox at gmail dot com" <zongbox at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, "adhemerval dot zanella at linaro dot org" <adhemerval dot zanella at linaro dot org>, "macro at wdc dot com" <macro at wdc dot com>, Alistair Francis <alistair23 at gmail dot com>, arcml <linux-snps-arc at lists dot infradead dot org>
- Date: Thu, 20 Feb 2020 09:24:08 +0100
- Subject: Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- References: <cover.1578824547.git.alistair.francis@wdc.com> <4e95f95966d8d7c6a8339160dc62d81c1f6a1bfb.1578824547.git.alistair.francis@wdc.com> <67f2298c-30ab-1508-4a10-6ee285df7ad1@synopsys.com> <CAKmqyKO6u15cDbQQ644GrABi=6WWQsNLiCVLszrmDCdcWBnCPA@mail.gmail.com> <c9f11e9e-7c33-0000-e32c-346d425d7c69@synopsys.com> <mvmimk3567z.fsf@suse.de> <8239db87-d736-a6e2-913d-c1e5e937688f@synopsys.com> <20200220001822.703ee8a1@jawa> <de8f8e28-630f-7b87-1a96-6131588a0346@synopsys.com> <alpine.DEB.2.21.2002200044040.28780@digraph.polyomino.org.uk>
On Thu, Feb 20, 2020 at 1:46 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Thu, 20 Feb 2020, Vineet Gupta wrote:
>
> > The first 4 will need more work as sym aliasing like
> > strong_alias (__xstat64, __xstat)
> >
> > will be needed in those ARM files (which in turn use i386).
>
> The situation for Arm is fundamentally different from that for ARC.
>
> For ARC, you only need a single public stat structure (using 64-bit times
> and offsets).
>
> For Arm, a third public stat structure will need to be added alongside the
> existing two, initially used internally in 64-bit-time stat functions that
> aren't exported from glibc, eventually to be used with _TIME_BITS=64 with
> the 64-bit-time stat interfaces exported once all the _TIME_BITS=64
> interfaces are ready.
But surely that structure layout would be the same on ARM and ARC
as well as all other 32-bit architectures with _TIME_BITS=64, right?
What's wrong with having a single implementation for the most
recent set of stat syscalls, with the older variants being only compiled
for architectures that need them to support _TIME_BITS=32 and/or
_FILE_OFFSET_BITS=32?
Arnd