This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "alistair23 at gmail dot com" <alistair23 at gmail dot com>, "linux-snps-arc at lists dot infradead dot org" <linux-snps-arc at lists dot infradead dot org>, "alistair dot francis at wdc dot com" <alistair dot francis at wdc dot com>
- Date: Tue, 25 Feb 2020 16:55:49 +0000
- Subject: Re: [PATCH v3] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B5eavFaxnVdHgnhCYaAGdpRRpEXBwcPyFVP+pajvjno=; b=Ngqa81TnYbF/CfO8vc2vmdPuznk/JCmZPGM02z0x2yQ9htFvhWQbBTmBwzjsD3kRKuRiFKD5VjVukm1WlDFblT/W037ZsN2wu49Cs10tPyNFo9xz/TcTV1gTHYxc/KQo9OZSQmQ1N1yG9WVsDIFpbgVds/r5bbVCDA3NF2qQJ3Yr0VqC8H4YFQMu4AAMa1arUi08NzCwB6vbb0+sypIPx8VMbMcYvVsTHsuN1jOqcpae06Ibbp8fDwTxbJuNDgMJMEy6VIJUSz7K1RVyNymzcNe6tX7xc6O9/0G8PZ1LW13GCy+mpz8+aeNMcP09oqr7dXa44Yutqc4jqMGQ4PnozA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8g0bVmN5Dj/CpjMcvtmzPW39EYOzsO8xJPfKh0nh8sxtFL9Af4OcWS5l4W553aPWSlMcCmvY43Yp6QoaCY5pbZMPluA1h0sPOW/UDvlqEtim7M5LsXDXgAhmJQjhtFQEG1k47cUcE5J0Hs87R2vBXSylJoe79mLA9W6cPTGwuPyYR7cFDb1QfEfEb8eAkZC6tkwIGc0ir40HKQap2h2vu2DOTqiJVfgm+j+Qg1TVuknvmkYLsJopJqO4bLZcCy37Fz+kxU5QpmqqY6DI7asV9l6J6G+ffFNzDw1cZaRxq0eKRNy796bZeyX9h/gAqbXHIq9B/cdMXUs3zr2+jipIQ==
- References: <alpine.DEB.2.21.2002250008160.23654@digraph.polyomino.org.uk> <20200225002941.20951-1-vgupta@synopsys.com> <df3e9d71-7d5b-a03b-7b6f-4aa034684307@gmail.com> <alpine.DEB.2.21.2002251609090.25788@digraph.polyomino.org.uk>
On 2/25/20 8:10 AM, Joseph Myers wrote:
> On Mon, 24 Feb 2020, Vineet Gupta wrote:
>
>> Oh wait. Can we avoid this churn by simply undef __NR_fstat64 and __NR_fstatat64
>> from ARC sysdep.h ? And it will then automatically fallback to statx code !
>
> If all files needing this information include sysdep.h, that might well
> work.
I agree that this is a valid concern. If we really want to make it water tight we
could have the build system enforce this with -include or some such ?