This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Rseq registration: Google tcmalloc vs glibc
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>, Chris Kennelly <ckennelly at google dot com>
- Cc: nd at arm dot com, "Joel Fernandes, Google" <joel at joelfernandes dot org>, Paul Turner <pjt at google dot com>, Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <codonell at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>, linux-kernel <linux-kernel at vger dot kernel dot org>, Peter Zijlstra <peterz at infradead dot org>, paulmck <paulmck at kernel dot org>, Boqun Feng <boqun dot feng at gmail dot com>, Brian Geffon <bgeffon at google dot com>
- Date: Thu, 27 Feb 2020 10:18:32 +0000
- Subject: Re: Rseq registration: Google tcmalloc vs glibc
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pwt7XfA3fTB9SOtrdHonklTf6XqXmWD1rqujmtrU/XU=; b=BOU9tOQycDoeayhCFvu+FSA37yjGks4I9SoS2fRJyXr3knciIN+nWxNUFI/OG8SewtD8Mks32CCoDPcveVOppbfNIBxGbpQiLf8Fbrj+OSvm+nqWW62c3ZuCxu2S+7Rrq/kt/x+NdN2ovSZmQZLO5FDW6INRBqZASx6Av5bJt0niyUlXDyzoLKv/6pz/hR5tB+6mktePgUexpJ0Ve5ShkwEZkIPZHZlbUWtl7ShtK9jn3IJcJOX8JxSZUgql+egWvvVmEwqZ9s7hmGjDdSmIeoXazxNmZkeE3IdqE0H0QR4dpkVDiJ8BnWKvicUiSNym9Vpl7zTZgxkT5R7RyE5q6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lBCWTaenWy/UY+mqOa8lVMTRQHbOu0+Zl1qmEpy+peJ3MTC2BbQiGc66jqPAzK/84CRpL0HJHeHMy/IUIXvPkSbIXsA3zvBMOWwhqGDGaijKeeuu1LRcW/7c1Jy2yfs5ZDaOmx80nJgogBN5uRbqISSGIxzX92vzXp9xVdkq6gx9WDi+IJriIBzqhRxxSoERyTWm3YejHcBgolJwqOg6Db47xHKgBrMgJXSfcTqdm2NfkTrPf6ts1Ax4BoET4jwdWczIXBZNcSuQxC6bAooV668J4QJDa/cAUbXcIBoci5FZJVxHgzZXvQIIkYiT0WK47zrrwfB3WPIKIjtOhTUuwA==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- References: <1503467992.2999.1582234410317.JavaMail.zimbra@efficios.com> <20200221154923.GC194360@google.com> <1683022606.3452.1582301632640.JavaMail.zimbra@efficios.com> <CAEXW_YRT7AjaJs7mPyNd=J6fhBicYwGbQMK2Senwm3cBhFvWPw@mail.gmail.com> <CAEE+ybmQb02u-=c1sHozkJ+RXOi2Hno6qYJ0Vx9rOpKjSQ4fPQ@mail.gmail.com> <1089333712.8657.1582736509318.JavaMail.zimbra@efficios.com> <CAEE+ybkTs4U7h-Js818k1QEqpVfHwAHSTXaEwHs3g37LwOsjLQ@mail.gmail.com> <982202794.8791.1582743392060.JavaMail.zimbra@efficios.com>
On 26/02/2020 18:56, Mathieu Desnoyers wrote:
> ----- On Feb 26, 2020, at 12:27 PM, Chris Kennelly ckennelly@google.com wrote:
>> I agree that this could potentially violate inviarants, but
>> InitFastPerCpu is not intended to be called by the application.
>
> OK, explicitly documenting this would be a good thing. In my own projects,
> I prefix those symbols with double-underscores (__) to indicate that those
> are not meant to be called by other means than the static inlines in the API.
use a different convention for that, __ prefix is always
reserved for the implementation for arbitrary use.
ideally internals would not be exposed in the user api
and then there is no such issue.