This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Rseq registration: Google tcmalloc vs glibc
- From: Florian Weimer <fweimer at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>, Chris Kennelly <ckennelly at google dot com>, nd at arm dot com, "Joel Fernandes\, Google" <joel at joelfernandes dot org>, Paul Turner <pjt at google dot com>, Carlos O'Donell <codonell at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>, linux-kernel <linux-kernel at vger dot kernel dot org>, Peter Zijlstra <peterz at infradead dot org>, paulmck <paulmck at kernel dot org>, Boqun Feng <boqun dot feng at gmail dot com>, Brian Geffon <bgeffon at google dot com>
- Date: Thu, 27 Feb 2020 11:32:45 +0100
- Subject: Re: Rseq registration: Google tcmalloc vs glibc
- References: <1503467992.2999.1582234410317.JavaMail.zimbra@efficios.com> <20200221154923.GC194360@google.com> <1683022606.3452.1582301632640.JavaMail.zimbra@efficios.com> <CAEXW_YRT7AjaJs7mPyNd=J6fhBicYwGbQMK2Senwm3cBhFvWPw@mail.gmail.com> <CAEE+ybmQb02u-=c1sHozkJ+RXOi2Hno6qYJ0Vx9rOpKjSQ4fPQ@mail.gmail.com> <1089333712.8657.1582736509318.JavaMail.zimbra@efficios.com> <CAEE+ybkTs4U7h-Js818k1QEqpVfHwAHSTXaEwHs3g37LwOsjLQ@mail.gmail.com> <982202794.8791.1582743392060.JavaMail.zimbra@efficios.com> <c79e3622-30df-001f-8f60-5a3edc10f7e5@arm.com>
* Szabolcs Nagy:
> On 26/02/2020 18:56, Mathieu Desnoyers wrote:
>> ----- On Feb 26, 2020, at 12:27 PM, Chris Kennelly ckennelly@google.com wrote:
>>> I agree that this could potentially violate inviarants, but
>>> InitFastPerCpu is not intended to be called by the application.
>>
>> OK, explicitly documenting this would be a good thing. In my own projects,
>> I prefix those symbols with double-underscores (__) to indicate that those
>> are not meant to be called by other means than the static inlines in the API.
>
> use a different convention for that, __ prefix is always
> reserved for the implementation for arbitrary use.
tcmalloc is *not* the implementation in that sense. It must not use the
__ prefix for its identifiers.
Thanks,
Florian