Re: [PATCH] powerpc: Fix feraiseexcept and feclearexcept macros

[Matheus Castanho <msc at linux dot ibm dot com>]

On 3/4/20 3:30 PM, Adhemerval Zanella wrote:
> 
> 
> On 04/03/2020 14:47, Florian Weimer wrote:
>> * Matheus Castanho:
>>
>>>> __builtin_popcount (e) == 1 does not
>>>> seem to be unreasonable to express this condition.
>>>>
>>>
>>> Adhemerval and Florian, apart from the discussion to remove or not
>>> fenvinline.h altogether, could we push this commit? This header is
>>> currently in a broken state and I'd like to fix it for the time being.
>>
>> I think the patch is okay, but please also wait for Adhemerval's
>> comments.
>>
>> I'd also be okay with powerof2 and a zero check.  I agree that we should
>> fix this soon.
> 
> I am fine with this patch as is, since either solution is fine. I will
> probably send a patch to just remove the fenvinline to start the
> discussion whether it is worth to keep continuing provide such
> optimization.

Sounds good to me.

Thanks,
Matheus Castanho