This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Optimize varuse_collecting_visitor::visit_embeddedcode by bool flags.
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: "Yichun Zhang \(agentzh\)" <yichun at openresty dot com>
- Cc: systemtap at sourceware dot org
- Date: Mon, 18 Mar 2019 09:11:20 -0400
- Subject: Re: [PATCH] Optimize varuse_collecting_visitor::visit_embeddedcode by bool flags.
- References: <20190316235459.24256-1-yichun@openresty.com>
yichun wrote:
> The varuse_collecting_visitor::visit_embeddedcode() method currently
> spends a lot of CPU time on the string comparison operations for the
> memo_tagged_p() function. [...]
Thanks for looking at this issue. Rather than inlining the logic
of all these tags into code sprinkled in multiple locations, what
do you think about an approach where
- the embedded_*::tagged_p() member functions look inside a member
dictionary rather than a global string_find_memoized[] one?
or
- making the global string_find_memoized[] map a hash table rather
than the default rbtree?
- FChE