This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Optimize varuse_collecting_visitor::visit_embeddedcode by bool flags.
- From: Yichun Zhang <yichun at openresty dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: systemtap at sourceware dot org
- Date: Tue, 19 Mar 2019 18:09:55 -0700
- Subject: Re: [PATCH] Optimize varuse_collecting_visitor::visit_embeddedcode by bool flags.
- References: <20190316235459.24256-1-yichun@openresty.com> <87k1gwpbs7.fsf@redhat.com>
Hello!
On Mon, Mar 18, 2019 at 6:11 AM Frank Ch. Eigler wrote:
> Thanks for looking at this issue. Rather than inlining the logic
> of all these tags into code sprinkled in multiple locations, what
> do you think about an approach where
>
> - the embedded_*::tagged_p() member functions look inside a member
> dictionary rather than a global string_find_memoized[] one?
>
> or
>
> - making the global string_find_memoized[] map a hash table rather
> than the default rbtree?
>
Just for the record, this conversation has been moved to this PR, as suggested:
https://sourceware.org/bugzilla/show_bug.cgi?id=24363
Best,
Yichun